Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quarkus-jackson to quarkus-oidc #5470

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Add quarkus-jackson to quarkus-oidc #5470

merged 1 commit into from
Nov 20, 2019

Conversation

sberyozkin
Copy link
Member

Fixes #5342.

@sberyozkin
Copy link
Member Author

Hi @gsmet @cescoffier I'm afraid of breaking things and not adding a Backport label, I'd rather say to 1.0.0 users they need to add a quarkus-jackson dependency manually if they need to run the oidc adapter in the native mode

@gsmet
Copy link
Member

gsmet commented Nov 14, 2019

Failure is unrelated, merging.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sberyozkin what's the relation between adding quarkus-jackson and removing the Keycloak test resource?

Blocking the merge until I've got an answer for that.

@sberyozkin
Copy link
Member Author

sberyozkin commented Nov 14, 2019

@gsmet not related, but I was cleaning up along the way, while checking the tests, looks like they were needed at some point of time to ensure keycloak.url was available to the tests (cc @pedroigor ) but I've checked if I can remove them and it worked :-)

@gsmet
Copy link
Member

gsmet commented Nov 14, 2019

And it works locally too without a Keycloak server started? Because I seem to recall we have one running on CI.

@pedroigor
Copy link
Contributor

pedroigor commented Nov 14, 2019

@gsmet not related, but I was cleaning up along the way, while checking the tests, looks like they were needed at some point of time to ensure keycloak.url was available to the tests (cc @pedroigor ) but I've checked if I can remove them and it worked :-)

I've added that due to

// a workaround to set system properties defined when executing tests. Looks like this commit introduced an
. If it works now without it, +1 to remove it.

Are you able to change the url when running locally?

@sberyozkin
Copy link
Member Author

sberyozkin commented Nov 14, 2019

@pedroigor @gsmet do you mean if I've run the tests locally ? Yes I did. May be worth double-checking, Pedro, please try ?

@sberyozkin
Copy link
Member Author

sberyozkin commented Nov 14, 2019

@pedroigor I was not changing the URLs with -Dkeycloak.utl=someother url- I just run the tests with -Pdocker-keycloak -Ptest-keycloak. I can restore those KeycloakResource files if that is still needed in some situations

@sberyozkin
Copy link
Member Author

sberyozkin commented Nov 14, 2019

@gsmet by the way I'm not sure if the OIDC native test passed in CI, looks like the job was terminated due to to some download issue ? Sorry, see it now :-) at https://dev.azure.com/quarkus-ci/quarkus/_build/results?buildId=12180

@sberyozkin
Copy link
Member Author

@gsmet IMHO this is good to go, as I said I've confirmed the native tests work in the master, both oidc and oidc-code-flow against a locally launched KC image. But the actual fix is not for 1.0.0.Final so the merge can wait till you may want to check it locally as well... Thanks

@gsmet gsmet merged commit b37b354 into quarkusio:master Nov 20, 2019
@gsmet
Copy link
Member

gsmet commented Nov 20, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus-oidc does not work in the native mode without quarkus-jackson
3 participants