-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quarkus-jackson to quarkus-oidc #5470
Conversation
Hi @gsmet @cescoffier I'm afraid of breaking things and not adding a Backport label, I'd rather say to 1.0.0 users they need to add a quarkus-jackson dependency manually if they need to run the oidc adapter in the native mode |
Failure is unrelated, merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sberyozkin what's the relation between adding quarkus-jackson
and removing the Keycloak test resource?
Blocking the merge until I've got an answer for that.
@gsmet not related, but I was cleaning up along the way, while checking the tests, looks like they were needed at some point of time to ensure |
And it works locally too without a Keycloak server started? Because I seem to recall we have one running on CI. |
I've added that due to quarkus/integration-tests/oidc/src/test/java/io/quarkus/it/keycloak/KeycloakTestResource.java Line 13 in c497d79
Are you able to change the url when running locally? |
@pedroigor @gsmet do you mean if I've run the tests locally ? Yes I did. May be worth double-checking, Pedro, please try ? |
@pedroigor I was not changing the URLs with |
@gsmet by the way I'm not sure if the OIDC native test passed in CI, looks like the job was terminated due to to some download issue ? Sorry, see it now :-) at https://dev.azure.com/quarkus-ci/quarkus/_build/results?buildId=12180 |
@gsmet IMHO this is good to go, as I said I've confirmed the native tests work in the master, both |
Thanks! |
Fixes #5342.