Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arc - support static producer methods. #5516

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Arc - support static producer methods. #5516

merged 1 commit into from
Nov 18, 2019

Conversation

manovotn
Copy link
Contributor

Fixes #5513

@manovotn manovotn requested a review from mkouba November 15, 2019 14:15
mkouba
mkouba requested changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentions "static producers" which includes static producer fields ;-).

manovotn
manovotn commented Nov 15, 2019
View reviewed changes
Copy link
Contributor Author

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkouba how about this version?
Sorry for missing the fields initially, I was just coding without thinking :)

@manovotn manovotn requested a review from mkouba November 15, 2019 17:40
@manovotn
Copy link
Contributor Author

The CI failure looks very much unrelated.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 18, 2019
@mkouba mkouba added this to the 1.1.0 milestone Nov 18, 2019
@stuartwdouglas stuartwdouglas merged commit b9436e8 into quarkusio:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.1.0.CR1
Development

Successfully merging this pull request may close these issues.

ArC - support static producers
3 participants
@manovotn @mkouba @stuartwdouglas