Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Quarkus artifacts before caching the repository on Azure #5520

Merged
merged 5 commits into from
Nov 28, 2019

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 15, 2019

No description provided.

@geoand
Copy link
Contributor

geoand commented Nov 17, 2019

@gsmet If you want me to also check anything out on this, let me know.

@machi1990
Copy link
Member

@gsmet @geoand given the latest CI failure on some PRs, can we continue with this experiment? :-)

@geoand
Copy link
Contributor

geoand commented Nov 20, 2019

Sure, I can help out but dunno how far @gsmet got

@gsmet
Copy link
Member Author

gsmet commented Nov 20, 2019

I need to revisit this, Azure doesn't support something I wanted to try.

@machi1990
Copy link
Member

Cool, let me know if I can be of help :-)

@cescoffier
Copy link
Member

Should we close this one or is there another attempt planned?

@gsmet
Copy link
Member Author

gsmet commented Nov 24, 2019

I did another experiment already 2 days ago but apparently without much success. Let me check the log.

@gsmet gsmet force-pushed the azure-avoid-caching branch 2 times, most recently from 02cc911 to 52fe3b9 Compare November 25, 2019 12:21
@@ -0,0 +1,4 @@
steps:
- script: find $(MAVEN_CACHE_FOLDER)io/quarkus/ -mindepth 1 -maxdepth 1 \( ! -name http -a ! -name gizmo -a ! -name security \) -exec rm -rf {} \;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment on this one a little?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what is unclear ;). Yeah right, I will add a comment.

@@ -32,7 +32,8 @@ stages:

- task: CacheBeta@0
inputs:
key: maven | bom/runtime/pom.xml #if we attempt to use all poms then when they get copied to target everything breaks. This should be good enough, it does not need to be perfect
# the number below is a cache version when we want to force a cache refresh
key: maven | "2" | bom/runtime/pom.xml #if we attempt to use all poms then when they get copied to target everything breaks. This should be good enough, it does not need to be perfect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that we will need to increment the version number somehow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's only because I really wanted to go from a clean cache and I didn't find another way to do it.

So basically, you just have to increment when you have buggy artifacts in your cache and you want to start from scratch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought, but just wanted to be sure

@gsmet gsmet force-pushed the azure-avoid-caching branch from d459b1a to da6b9af Compare November 26, 2019 10:49
@geoand
Copy link
Contributor

geoand commented Nov 26, 2019

I don't have any Azure CI experience, but these changes do make sense to me

@gsmet gsmet marked this pull request as ready for review November 27, 2019 17:17
@gsmet
Copy link
Member Author

gsmet commented Nov 27, 2019

@geoand I think we should try to merge that one and see if it improves things.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should try it

@geoand
Copy link
Contributor

geoand commented Nov 27, 2019

Perhaps we should wait for after 1.0.1 in case something goes wrong?

@gsmet
Copy link
Member Author

gsmet commented Nov 27, 2019

Sure, we can wait until tomorrow afternoon.

@geoand
Copy link
Contributor

geoand commented Nov 28, 2019

@gsmet time to merge?

@gsmet gsmet merged commit e4afde6 into quarkusio:master Nov 28, 2019
@gsmet gsmet changed the title Experimenting with the Azure cache Remove Quarkus artifacts before caching the repository on Azure Nov 28, 2019
@gsmet gsmet added this to the 1.1.0 milestone Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants