Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing of an existing executable #5609

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@@ -109,11 +109,24 @@ private static String guessPath(Class<?> testClass) {
return file.getAbsolutePath();
}
}
} else if (url.getProtocol().equals("file") && url.getPath().contains("/target/surefire/")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these paths work on Windows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, it is a URL path so I think so, either way windows support for native is pretty limited at the moment AFAIK, and the runner would probably have a .exe extension so that would not work either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

gsmet
gsmet previously requested changes Nov 20, 2019
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let @rsvoboda test this one before merging because he was the one asking.

@rsvoboda can you check that it solves your initial complaint?

Thanks!

@rsvoboda
Copy link
Member

Sure, but need to tackle wf/eap stuff first. Will look into it today for sure

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did mvn verify -Dnative && mvn failsafe:integration-test and native image got compiled only once !

Small disadvantage is that 3.0.0-M4 gets used - [INFO] --- maven-failsafe-plugin:3.0.0-M4:integration-test (default-cli) @ getting-started ---, pom.xml uses 2.22.0.

mvn org.apache.maven.plugins:maven-failsafe-plugin:2.22.0:integration-test is workaround for this.

Also tried to modify one test, changes were reflected.

One thing which I didn't like are these super long = lines:

[INFO] Running org.acme.quickstart.NativeGreetingResourceIT
=================================================================================================================================================================
=native.image.path was not set, making a guess that  /Users/rsvoboda/tmp/getting-started/target/getting-started-1.0-SNAPSHOT-runner is the correct native image=
=================================================================================================================================================================

But it's not related to this change

@mkouba
Copy link
Contributor

mkouba commented Nov 20, 2019

Small disadvantage is that 3.0.0-M4 gets used - [INFO] --- maven-failsafe-plugin:3.0.0-M4:integration-test (default-cli) @ getting-started ---, pom.xml uses 2.22.0.

Ok, that's because your profile defines a different version of failsafe, right? In that case, I'd prefer to define the failsafe version outside the native profile. However, in that case you wouldn't need to run mvn verify -Dnative && mvn failsafe:integration-test because mvn verify -Dnative && mvn verify would work as well (#5588 (comment)). But I may be missing something obvious. In any case, Stuart's change is OK.

@gsmet gsmet dismissed their stale review November 20, 2019 19:17

Rostislav tested it.

@gsmet gsmet merged commit f39cb30 into quarkusio:master Nov 20, 2019
@gsmet gsmet added this to the 1.1.0 milestone Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants