-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow testing of an existing executable #5609
Conversation
@@ -109,11 +109,24 @@ private static String guessPath(Class<?> testClass) { | |||
return file.getAbsolutePath(); | |||
} | |||
} | |||
} else if (url.getProtocol().equals("file") && url.getPath().contains("/target/surefire/")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these paths work on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, it is a URL path so I think so, either way windows support for native is pretty limited at the moment AFAIK, and the runner would probably have a .exe extension so that would not work either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but need to tackle wf/eap stuff first. Will look into it today for sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did mvn verify -Dnative && mvn failsafe:integration-test
and native image got compiled only once !
Small disadvantage is that 3.0.0-M4 gets used - [INFO] --- maven-failsafe-plugin:3.0.0-M4:integration-test (default-cli) @ getting-started ---
, pom.xml uses 2.22.0.
mvn org.apache.maven.plugins:maven-failsafe-plugin:2.22.0:integration-test
is workaround for this.
Also tried to modify one test, changes were reflected.
One thing which I didn't like are these super long =
lines:
[INFO] Running org.acme.quickstart.NativeGreetingResourceIT
=================================================================================================================================================================
=native.image.path was not set, making a guess that /Users/rsvoboda/tmp/getting-started/target/getting-started-1.0-SNAPSHOT-runner is the correct native image=
=================================================================================================================================================================
But it's not related to this change
Ok, that's because your profile defines a different version of failsafe, right? In that case, I'd prefer to define the failsafe version outside the native profile. However, in that case you wouldn't need to run |
No description provided.