Add more GizmoAdaptor stuff #5670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, it might be a stupid question but can we use Gizmo when transforming an existing class? For an HV POC, I ended up using ASM directly as that's what others did but it would be nice to be able to use Gizmo for that too. |
|
From what I have seen from Gizmo, that isn't supported. |
gsmet
approved these changes
Nov 22, 2019
|
You asked for @mkouba 's review so I let him have the final say. |
|
Only because @mkouba had reviewed the previous PR, no other special reason |
mkouba
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of: #5646