Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - introduce BeanStream #5830

Merged
merged 1 commit into from
Nov 29, 2019
Merged

ArC - introduce BeanStream #5830

merged 1 commit into from
Nov 29, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 28, 2019

@mkouba mkouba added this to the 1.1.0 milestone Nov 28, 2019
@mkouba mkouba requested a review from manovotn November 28, 2019 12:16
manovotn
manovotn reviewed Nov 28, 2019
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bunch of comments but overall this is looking real good!

@mkouba mkouba requested a review from manovotn November 29, 2019 07:59
@manovotn
Copy link
Contributor

@mkouba Imports are not sorted in /home/vsts/work/1/s/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanStream.java ;-)

@mkouba
ArC - introduce BeanStream
bb448c0 
- convenient Stream wrapper that can be used to filter beans
- allow for inspecting removed beans in BeanDeploymentValidator
- also make it possible to mark a synthetic bean as unremovable
- resolves quarkusio#5653
@mkouba
Copy link
Contributor Author

mkouba commented Nov 29, 2019

Yeah, I know. Just fixed it now.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 29, 2019
@mkouba mkouba merged commit 204284d into quarkusio:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.1.0.CR1
Development

Successfully merging this pull request may close these issues.

ArC build-time metadata - make it possible to query the registered beans
2 participants
@mkouba @manovotn