-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support logging to Sentry #5881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failures seem irrelevant and might be due to artifact caching. Can you please rebase onto the latest master? |
dmlloyd
reviewed
Nov 29, 2019
extensions/logging-sentry/runtime/src/main/java/io/quarkus/sentry/SentryConfig.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Nov 29, 2019
extensions/logging-sentry/runtime/src/main/java/io/quarkus/sentry/SentryConfig.java
Outdated
Show resolved
Hide resolved
67b18e0
to
c887a5d
Compare
Ok then ;-)
…On Mon, Dec 2, 2019 at 1:33 PM David M. Lloyd ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
extensions/logging-sentry/runtime/src/main/java/io/quarkus/sentry/SentryConfig.java
<#5881 (comment)>:
> + */
+ @configitem(defaultValue = "WARNING")
+ public Level level;
+
+ /**
+ * Sentry differentiates stack frames that are directly related to your application (“in application”) from stack frames
+ * that come from other packages such as the standard library, frameworks, or other dependencies. The difference is visible
+ * in the Sentry web interface where only the “in application” frames are displayed by default.
+ *
+ * You can configure which package prefixes your application uses with this option, which takes a comma separated list.
+ *
+ * This option is highly recommended as it affects stacktrace grouping and display on Sentry. See documentation:
+ * https://docs.sentry.io/clients/java/config/#in-application-stack-frames
+ */
+ @configitem
+ public Optional<String> packages;
I think it's important for all of our lists to be formatted the same way
whenever possible.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5881?email_source=notifications&email_token=AAQ664FDFYZYAXNXIF527KDQWT57ZA5CNFSM4JTAXHIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNREABI#discussion_r352570785>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ664ECOKGSE6MDYOW4XVDQWT57ZANCNFSM4JTAXHIA>
.
--
Andy Damevin
|
c887a5d
to
f8185fe
Compare
dmlloyd
reviewed
Dec 2, 2019
...ogging-sentry/runtime/src/main/java/io/quarkus/logging/sentry/SentryHandlerValueFactory.java
Outdated
Show resolved
Hide resolved
extensions/logging-sentry/runtime/src/main/java/io/quarkus/logging/sentry/SentryConfig.java
Show resolved
Hide resolved
f8185fe
to
78648d0
Compare
dmlloyd
approved these changes
Dec 2, 2019
0546b44
to
c6406c2
Compare
c6406c2
to
09dfc0e
Compare
I need to add something to the doc (adding WIP status to not merge) |
09dfc0e
to
30a6027
Compare
Ok, I've done my changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3985