Use Vert.x BodyHandler #5978
Use Vert.x BodyHandler #5978
Conversation
| @@ -21,6 +22,12 @@ FeatureBuildItem featureBuildItem() { | |||
| return new FeatureBuildItem(FeatureBuildItem.KEYCLOAK_AUTHORIZATION); | |||
| } | |||
|
|
|||
| @BuildStep | |||
| RequireBodyHandlerBuildItem requireBody() { | |||
| //TODO: this should only be produced if required, ask Pedro about config for this | |||
There was a problem hiding this comment.
@pedroigor how can we tell if the request needs to be fully buffered or not?
| } | ||
| } | ||
|
|
||
| return value; |
There was a problem hiding this comment.
What's the reason for this change? It looks a bit unrelated and unexpected.
There was a problem hiding this comment.
@gsmet Indeed, the reason behind it is that otherwise, we would need a Keycloak release to just fix how we are checking the content type. The code here is basically removing the charset so that the code we are relying on from Keycloak can work as expected.
There was a problem hiding this comment.
That was part of @pedroigor original approach, I don't think it is needed so I might modify the PR to just keep the tests and not the rest of the changes.
There was a problem hiding this comment.
Yeah, the change is not related with this one but to #5959
There was a problem hiding this comment.
OK, then this needs proper documentation with a TODO pointing to a GH issue so that we remove it in the future.
stuartwdouglas
force-pushed
the
vertx-body-handler
branch
3 times, most recently
from
ec08512 to
ceacd10
Compare
Fixes quarkusio#5959 This change allows the body handler to be used for Undertow and RESTEasy standalone. When the request is fully buffered it can be consumed multiple times, which allows keycloak to also process it.
stuartwdouglas
force-pushed
the
vertx-body-handler
branch
from
ceacd10 to
2fb8415
Compare
| } | ||
| } | ||
|
|
||
| return value; |
There was a problem hiding this comment.
@gsmet Indeed, the reason behind it is that otherwise, we would need a Keycloak release to just fix how we are checking the content type. The code here is basically removing the charset so that the code we are relying on from Keycloak can work as expected.
There was a problem hiding this comment.
@stuartwdouglas you need to remove any change related to tests because the previous change I did to content type (VertxHttpFacade) is not here anymore (but will be sent separately on top of your work). Otherwise, the test will fail. The files that should be reverted are: ProtectedResource, application.properties and PolicyEnforcerTest.
|
Superseded by #5981 which includes this work. |
gsmet
added
triage/out-of-date
Fixes #5959
This change allows the body handler to be used for Undertow
and RESTEasy standalone. When the request is fully buffered
it can be consumed multiple times, which allows keycloak
to also process it.