Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jackson integration test #5997

Merged
merged 2 commits into from
Dec 7, 2019
Merged

Fix jackson integration test #5997

merged 2 commits into from
Dec 7, 2019

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 6, 2019

No description provided.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 6, 2019
@geoand
Copy link
Contributor Author

geoand commented Dec 6, 2019

Weird that CI hasn't even picked this up...

@gsmet
Copy link
Member

gsmet commented Dec 6, 2019

CI wasn't triggered for now so let's wait if Azure gets triggered or I'll force push this week-end.

Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwenneg gwenneg merged commit 3e0ff60 into quarkusio:master Dec 7, 2019
@gwenneg
Copy link
Member

gwenneg commented Dec 7, 2019

Sorry, I didn't pay enough attention to the number of passed checks. This shouldn't have been merged. I'll keep an eye on CI to make sure everything's OK.

@gwenneg
Copy link
Member

gwenneg commented Dec 7, 2019

CI is broken on master, I submitted #6000 to fix it. I'll never ever merge something that late and without checking twice the CI checks list! Again, sorry about all this :(

@geoand
Copy link
Contributor Author

geoand commented Dec 7, 2019

No worries!

It was a bit of a special case with CI completely failing to start...

Thanks for fixing in the follow up PR

@geoand geoand deleted the #5993 branch December 7, 2019 08:14
@gsmet gsmet added this to the 1.1.0 milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants