#5950 Pulling up user creation in Dockerfile for layer caching

[gunnarmorling]

In case of rebuilding an image, the create user command would run again before, as it came after the more volatile commands for adding dependencies and runner.

Fixes: #5950

[gunnarmorling]

Not sure how to test this. I did the change first in an actual project and can confirm it works there. But of course I could have messed up when transferring the change into the template. Is there an easy way I can materialize the template again so to see whether it's working correctly?

[geoand]

I added a minor comment, looks good otherwise

[geoand]

You can test the new templates by generating a project according to what has been documented in at: 4dec5b8

[gunnarmorling]

Force-pushed for the typo fix. Thx for the hint on snapshot testing. Will do later today and report back.

…

[geoand]

Great, thanks!

[gsmet]

It's minor but it the second time you do it IIRC: could we avoid the ; at the end of the commit line?

Thanks.

[gunnarmorling]

No problem, I can remove it If you prefer. NB it's intentionally done to indicate that there's more in the message than the leading line, which I find a useful hint as in many places you only get shown the first line of commit messages.

[gsmet]

Well, it won't work very well in a project with 200 committers and you're the only one doing it :).

Let's get rid of it.

[gunnarmorling]

Well, it won't work very well in a project with 200 committers and you're the only one doing it :)

Obviously, the 199 others should do as I do ;) Until then, I've removed it.

Also tested the snapshot template version as suggested by @geoand. All looks good, here's the log showing how the ADD USER command is cached after a code change:

docker build -f src/main/docker/Dockerfile.jvm -t quarkus/quarkus-5950-jvm .
Sending build context to Docker daemon   9.39MB
Step 1/9 : FROM fabric8/java-alpine-openjdk8-jre:1.6.5
 ---> e169b1c71a87
Step 2/9 : ENV JAVA_OPTIONS="-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager"
 ---> Using cache
 ---> 4cfb18e98d5a
Step 3/9 : ENV AB_ENABLED=jmx_exporter
 ---> Using cache
 ---> b227b10c9fef
Step 4/9 : RUN adduser -G root --no-create-home --disabled-password 1001   && chown -R 1001 /deployments   && chmod -R "g+rwX" /deployments   && chown -R 1001:root /deployments
 ---> Using cache
 ---> c8df6ada7d35
Step 5/9 : COPY target/lib/* /deployments/lib/
 ---> Using cache
 ---> 74f113b90ada
Step 6/9 : COPY target/*-runner.jar /deployments/app.jar
 ---> 1c0d783686e1
Step 7/9 : EXPOSE 8080
 ---> Running in 97d37ce8db03
Removing intermediate container 97d37ce8db03
 ---> 33a63879c6da
Step 8/9 : USER 1001
 ---> Running in 2d1977e3716e
Removing intermediate container 2d1977e3716e
 ---> dd5f8b4d9566
Step 9/9 : ENTRYPOINT [ "/deployments/run-java.sh" ]
 ---> Running in b57a6bfc8fb9
Removing intermediate container b57a6bfc8fb9
 ---> b48b92145535
Successfully built b48b92145535
Successfully tagged quarkus/quarkus-5950-jvm:latest

[geoand]

Thanks @gunnarmorling!!!

[geoand]

@gsmet do you plan on backporting this one?

[gsmet]

I haven't created the branch yet tbh.

If you think that's something we should have in 1.1, let's merge it once CI is green.

[gsmet]

Merged, thanks.