Fixes Gradle build in Scala projects #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
changed the title
gastaldi
changed the title
gastaldi
changed the title
gastaldi
changed the title
geoand
reviewed
Dec 23, 2019
|
|
||
| /** | ||
| * Returns the last file from the specified {@link FileCollection}. | ||
| * Needed for the Scala plugin. |
geoand
reviewed
Dec 23, 2019
devtools/gradle/src/functionalTest/java/io/quarkus/gradle/QuarkusPluginFunctionalTest.java
Show resolved
Hide resolved
|
This is how I tell the ProjectGenerator that I need a JAX-RS endpoint too.
Em Seg, 23 de dez de 2019 03:15, Georgios Andrianakis <
[email protected]> escreveu:
… ***@***.**** commented on this pull request.
------------------------------
In
devtools/gradle/src/functionalTest/java/io/quarkus/gradle/QuarkusPluginFunctionalTest.java
<#6317 (comment)>:
> @@ -74,13 +74,16 @@ public void canBuild(SourceType sourceType) throws IOException {
}
private void createProject(SourceType sourceType) throws IOException {
+ Map<String,Object> context = new HashMap<>();
+ context.put("path", "/greeting");
I don't really understand what this is necessary. Can you please elaborate?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6317?email_source=notifications&email_token=AAANG5OZ5IEI3JYAJZDWII3Q2BJQFA5CNFSM4J6O4L22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQBL32A#pullrequestreview-335724008>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANG5LL2HEXPNYK6HAQ5RDQ2BJQFANCNFSM4J6O4L2Q>
.
|
|
Oh, ok makes sense |
geoand
approved these changes
Dec 23, 2019
gsmet
approved these changes
Dec 23, 2019
gsmet
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6316