Don't restart on web resource change #6666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web resources should be modifiable without causing a restart. Fixes quarkusio#6417
|
@ia3andy mind giving this PR as shot? |
geoand
reviewed
Jan 21, 2020
| @@ -39,16 +52,21 @@ | |||
| @Priority(Priorities.USER + 1) | |||
| public class NotFoundExceptionMapper implements ExceptionMapper<NotFoundException> { | |||
|
|
|||
| protected static final String META_INF_RESOURCES_SLASH = "META-INF/resources/"; | |||
There was a problem hiding this comment.
Perhaps avoid the META-INF/resources duplication?
There was a problem hiding this comment.
Does it really matter? The JVM inlines them so it does not add any overhead.
There was a problem hiding this comment.
Of course it doesn't matter :).
Just as a hygiene thing, nothing more. I'm definitely not going to hold up the PR on this :)
|
@geoand no more errors 👍 |
|
Thanks for checking @ia3andy. PR looks good to me apart for a super minor comment I added |
geoand
approved these changes
Jan 21, 2020
|
The number of this PR is pretty evil, four 6s in a row :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web resources should be modifiable without causing a restart.
Fixes #6417