Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve the Kubernetes extension docs slightly #6689

Merged
merged 1 commit into from
Jan 21, 2020
Merged

doc: improve the Kubernetes extension docs slightly #6689

merged 1 commit into from
Jan 21, 2020

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jan 21, 2020

No description provided.

@Ladicek Ladicek requested a review from iocanel January 21, 2020 14:29
gsmet
gsmet requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted another preexisting typo.

@Ladicek
Copy link
Contributor Author

Ladicek commented Jan 21, 2020

Yay, thanks :-)

iocanel
iocanel approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet force-pushed the kubernetes-extension-docs branch from 9291208 to 07b32f4 Compare January 21, 2020 14:44
@gsmet gsmet merged commit bbe3de7 into quarkusio:master Jan 21, 2020
@gsmet
Copy link
Member

gsmet commented Jan 21, 2020

I squashed the 2 commits. Thanks!

1 similar comment
@gsmet
Copy link
Member

gsmet commented Jan 21, 2020

I squashed the 2 commits. Thanks!

@gsmet gsmet added this to the 1.3.0 milestone Jan 21, 2020
@Ladicek Ladicek deleted the kubernetes-extension-docs branch January 21, 2020 14:46
@gsmet gsmet modified the milestones: 1.3.0, 1.2.0.Final Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
1.2.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@Ladicek @gsmet @iocanel