Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show image pull output when using a builder image #6897

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 30, 2020

Fixes: #6892

@geoand geoand requested review from gastaldi and ia3andy January 30, 2020 19:43
@geoand geoand added this to the 1.3.0 milestone Jan 30, 2020
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor Author

geoand commented Jan 30, 2020

I also verified manually that the output does show up.

Plus since we use docker builds in CI, one can always look there when it's done to see the expected output

@ia3andy
Copy link
Contributor

ia3andy commented Jan 31, 2020

@geoand I will test it in a few minutes ;-) thanks!!

@geoand
Copy link
Contributor Author

geoand commented Jan 31, 2020

@ia3andy you should see something like:

2020-01-31T07:17:19.8338408Z [INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Pulling image quay.io/quarkus/ubi-quarkus-native-image:19.3.1-java8
2020-01-31T07:17:21.0472365Z 19.3.1-java8: Pulling from quarkus/ubi-quarkus-native-image
2020-01-31T07:17:21.0481614Z 57de4da701b5: Pulling fs layer
2020-01-31T07:17:21.0500610Z cf0f3ebe9f53: Pulling fs layer
2020-01-31T07:17:21.0506723Z 74e4ceac2598: Pulling fs layer
2020-01-31T07:17:21.4158146Z cf0f3ebe9f53: Verifying Checksum
2020-01-31T07:17:21.4158656Z cf0f3ebe9f53: Download complete
2020-01-31T07:17:21.6920223Z 57de4da701b5: Verifying Checksum
2020-01-31T07:17:21.6921583Z 57de4da701b5: Download complete
2020-01-31T07:17:23.7386786Z 57de4da701b5: Pull complete
2020-01-31T07:17:23.8816428Z cf0f3ebe9f53: Pull complete
2020-01-31T07:17:24.9466170Z 74e4ceac2598: Verifying Checksum
2020-01-31T07:17:24.9467331Z 74e4ceac2598: Download complete
2020-01-31T07:17:39.8790892Z 74e4ceac2598: Pull complete

@ia3andy
Copy link
Contributor

ia3andy commented Jan 31, 2020

It works great! It looks like a small thing but it look less buggy now :) Very good job

@ia3andy ia3andy merged commit 48f1610 into quarkusio:master Jan 31, 2020
@geoand geoand deleted the #6892 branch January 31, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using -Dquarkus.native.container-build to build container native build should display progress logs
4 participants