Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change resource name to PersonResource to align docs with Mongo Panache quickstarts #6958

Merged
merged 1 commit into from
Feb 3, 2020
Merged

change resource name to PersonResource to align docs with Mongo Panache quickstarts #6958

merged 1 commit into from
Feb 3, 2020
+4 −4

Conversation

machi1990
Copy link
Member

@machi1990 machi1990 commented Feb 3, 2020 •
edited
Loading

@machi1990 machi1990 force-pushed the docs/review-mongo-panache-project-creation-command branch from 0fcf42d to 202be72 Compare February 3, 2020 12:08
@machi1990 machi1990 changed the title docs: change resource name to PersonResource to align docs with quickstarts change resource name to PersonResource to align docs with Mongo Panache quickstarts Feb 3, 2020
@machi1990 machi1990 requested a review from gsmet February 3, 2020 12:10
gsmet
gsmet approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's wait for @loicmathieu 's blessing.

@gsmet gsmet requested a review from loicmathieu February 3, 2020 12:47
loicmathieu
loicmathieu approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@machi1990
Copy link
Member Author

Thanks @gsmet @loicmathieu. Merging now!

@machi1990 machi1990 merged commit 40079ee into quarkusio:master Feb 3, 2020
@machi1990 machi1990 deleted the docs/review-mongo-panache-project-creation-command branch February 3, 2020 15:03
@gsmet gsmet added this to the 1.3.0.Alpha1 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
1.3.0.Alpha1
Development

Successfully merging this pull request may close these issues.
3 participants
@machi1990 @gsmet @loicmathieu