Qute: Support iterating by number

[gastaldi]

I reused the for instruction to iterate by number. Support for descending order is not yet implemented. Let me see how that works for you @lordofthejars

Fixes #6963

[gastaldi]

Also feel free to reject/close this PR if it doesn't make sense @mkouba :)

[lordofthejars]

For me, it works really well as the only thing I want to do is print the number of stars depending on a rating number. So if it is 4 I just want to add 4 stars. The other thing as you said is the descending order but for now, if this is accepted I can work around the problem with not much effort.

Thank you very much.

[gastaldi]

The other thing as you said is the descending order but for now, if this is accepted I can work around the problem with not much effort.

Yeah, you can always do a total - (i - 1) instead of i if you want a descending order anyway :)

EDIT: It seems like math expressions are not supported yet

[mkouba]

@gastaldi looks good ;-).

It seems like math expressions are not supported yet

Yep, complex expressions are not supported in loops.

By the way, you can also use the {#each} variant here, e.g. something like:

{#each movie.numberOfStars}
  ...print star
{/each}

[gastaldi]

Can we get this PR approved and merged in time for 1.3.0.Alpha1?

[gsmet]

Just a small comment: let's not put pressure when none is needed. 1.3.0.Alpha1 is released for people to test the new class loading infra. We don't need to hurry to get this sort of fixes in: we can take our time to get a proper design if needed.

[gastaldi]

Hm, while reading the docs, I noticed that you could have also used an IntStream instead in an extension method:

Eg.

public IntStream getMovies() {
   return IntStream.rangeClosed(1, getMoviesCount()); 
}

Anyway, I added some docs adding support for plain Integers, let me know what you guys think :)

[gsmet]

@mkouba could you review the doc?

[mkouba]

@gastaldi Yes, extension methods would work too, ie. something like:

public static IntStream getMovieStars(Movie movie) {
   return IntStream.rangeClosed(1, movie.getStarsCount()); 
}

Anyway, I think it's ok to support this directly.

[DaHoC]

Proposing to also support iterating Long numbers: #41679