-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Pipeline to run TCK's with JDK 11 #6985
Conversation
@radcortez yes, it always executes things with the pipeline you push in the PR. I would wait for the issue to be fixed to merge that one, considering how many CI failures we have right now, not a good idea to add more. |
Sure. |
Related to this #5691 |
It seems that the CI TCK build with JDK 11 passed: https://dev.azure.com/quarkus-ci/quarkus/_build/results?buildId=15408&view=logs&jobId=4e5cd090-1efa-5ada-1b33-a7514eebccff Not sure what might be wrong. I've built locally and when running the TCK with JDK 11 I always get a failure here:
And with JDK 8:
I've build Quarkus with the current master using the same settings as the CI. I've asked another person to try it in their local box with the same issue. At this point the only difference I see is OS. I know you are overload @gsmet . I'm wondering if you can give it a try to see if you can also reproduce locally, or if there is something I'm doing wrong with the build. Thanks! |
@gastaldi could you see if you can reproduce this with JDK 11? |
I see the same errors using OpenJDK 11.0.6 in Fedora 31:
|
Seeing the same on my macOS.
|
No errors with JDK 8 |
Also related to #6841 |
Thanks @gastaldi and @machi1990. So also fails in non Mac systems. I'm wondering why it didn't fail in the CI: https://dev.azure.com/quarkus-ci/quarkus/_build/results?buildId=15408&view=logs&jobId=4e5cd090-1efa-5ada-1b33-a7514eebccff It executed with JDK 11: |
I'm wondering if the classloader has multiple copies of the offending class and it becomes an issue of ordering? |
I'll try building again in my machine and if it passes I think it's safe to merge |
Thanks! I confirm that the fix worked for me. But yes, it would be great if you can confirm as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ran the tests locally and I also confirm they pass after that fix
Cool. Thanks! |
No description provided.