refactor: Kubernetes extension now uses quarkus.

[iocanel]

This pull request adds the quarkus. prefix to kubernetes related properties.
For backwards compatibility it still supports the prefix-less properties.

The change is also applied in the docs & tests.

[gsmet]

I don't see any config classes there? Don't you have a ton of warnings about unused properties?

[iocanel]

I don't see any config classes there? Don't you have a ton of warnings about unused properties?

The change is about the properties that are being sent pass-through to dekorate, so there is no config class for them.

[gsmet]

Yes, but if you have quarkus. properties without config classes, IIRC, you get some warnings.

/cc @geoand

[iocanel]

I see.
Yeah upon closer inspection I do get those warnings.

[geoand]

Yeah that's something we'll need to take care of.

…

On Fri, Feb 21, 2020, 18:55 Ioannis Canellos ***@***.***> wrote: I see. Yeah upon closer inspection I do get those warnings. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7339?email_source=notifications&email_token=ABBMDPYKS43GXPE5BL65Q53REABOPA5CNFSM4KZGOFIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMTLN3Y#issuecomment-589739759>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDP4C5S6CUHIX2DD6W2TREABOPANCNFSM4KZGOFIA> .

[iocanel]

@angelozerr: FYI: This pull request brings in proper quarkus config classes for all properties.

[geoand]

That is absolutely great! Thanks for the hard work that you put into this! I'll have some time later on today to go over it

[geoand]

I added a bunch of small comments.

FWIW I think this work is great and is great step forward for the user friendliness of the kubernetes extension!
If you don't have time to take care of this comments yourself, please and let me know and I can fix them myself later on today so we can get this in ASAP

[geoand]

When done taking care of the comments, can you please resolve them?

Thanks

[geoand]

The CI failure is totally unrelated, but in any case CI will run again when the next round of fixes comes in

[iocanel]

@geoand: There are no pending fixes. So, we may need to rebase/kick again?

[geoand]

@iocanel I don't think all of the comments have been addressed. I think that you have missed the middle ones (that github probably grouped under xxx hidden conversations)

[geoand]

Please ping me once they are addressed so I can review and merge ASAP - it would be great to have this in for 1.3.CR1

[iocanel]

Please ping me once they are addressed so I can review and merge ASAP - it would be great to have this in for 1.3.CR1

I think that now even the middle items have been addressed.

[geoand]

This is great step forward. Any improvements can definitely be made in the time between CR1 and Final

Proper config objects have been created

[angelozerr]

@angelozerr: FYI: This pull request brings in proper quarkus config classes for all properties.

Thanks @iocanel for this great info. As you are using ConfigRoot it should work without developping something. But the question is to we need to continue to provide kubernetes.* properties in the completion?