Fix broken MongoClientBuildItem support

[geoand]

Fixes: #7378

[geoand]

There is one thing that needs to change however for MongoClientBuildItem.

The value of each RuntimeValue needs to become an optional instead of an actual client. The reason is that if the client is never injected into application code, the bean is never created.

[loicmathieu]

The reason is that if the client is never injected into application code, the bean is never created.

This is the behaviour I will need to change ...

[geoand]

The reason is that if the client is never injected into application code, the bean is never created.

This is the behaviour I will need to change ...

Yes of course, but it's necessary, otherwise we need to make the beans unremovable which goes counter to the point of the optimization :)

[loicmathieu]

we need to make the beans unremovable which goes counter to the point of the optimization :)

I don't really see the point of defining a mongoclient connection and not using it in the code. I don't think that bean removal should cover such case.

[geoand]

That's not the issue 😉

The issue is that user code can use only the blocking client and not the reactive client. In that case, no bean will be created for the reactive client. Ditto if the opposite happens.

We definitely can make the beans unremoveable, but that goes counter to what the optimization actually is meant for.

[loicmathieu]

That's not the issue

That's mine, but I will look at it later, let stop the digression here :)

[geoand]

I am not hell bent on the Optional thing, I'm just saying it's the proper thing to do. If it's too much of a hassle for the consumers of the Build Item to update, then we can make the bean unremovable :)

[loicmathieu]

@geoand in fact I just have an enlightment (I don't know if it's the correct word). @MongoClientName as a base for removing bean is not suitable for my use case but I have the @MongoEntity(clientName) annotation so I should be able to define a UnremovableBeanBuildItem to tell Arc to avoid removing the client I need even if the @MongoClientName is not used ! This will fix my issue ! 🎉

[geoand]

Excellent 👌

[loicmathieu]

LGTM but I will need to test it to see if it fixes my issue.
Maybe hold on to merge it untill I have time to test it (end of week)

[geoand]

The issue is we really need this for Camel. So I propose merging ASAP and then making any extra charges if necessary when you have the time to test

[loicmathieu]

I'm OK with this, I didn't saw prior to my comment that it fixes the issue for Camel.
So let's merge it, I'll give you feedback later on this.

[geoand]

Thanks

[gsmet]

I don't have the time to carefully review this so I'm gonna trust you on that one, considering it's blocking for Camel and CI is green.