Upgrade Maven resolver related dependencies used by bootstrap #7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e used by/compatible with Maven 3.6.3 release
aloubyansky
force-pushed
the
upgrade-maven-363
branch
from
acd49a0 to
ac430ef
Compare
gsmet
approved these changes
Feb 27, 2020
| final ClassInfo classInfo = index.getClassByName(clazz); | ||
| if (classInfo != null) { | ||
| ret.add(classInfo); | ||
| } |
There was a problem hiding this comment.
@geoand can you check that change?
There was a problem hiding this comment.
Well, not at this line exactly.
geoand
approved these changes
Feb 27, 2020
|
If you want to reproduce it @geoand, take this commit an undo that particular change. |
|
I'll do that now |
|
@aloubyansky which test failed? I can't seem to reproduce |
|
I think it was in spring-di deployment. |
|
or in the IT. Sorry, don't remember for sure. Do you want me to reproduce it for you? I even remember logging the annotation. I think it was javax.annotation.Nonnull. |
|
I tried the deployment module and all Spring ITs and nothing tripped... |
|
Ok, I'll try again. |
|
Oh, nevermind, I was able to reproduce it now |
|
OK, fix is good and should have been there in the first place :). Thanks @aloubyansky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to those used by/compatible with Maven 3.6.3 release
Fixes #3539
Fixes #7458