Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of hibernate orm bind params #7498

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

Postremus
Copy link
Member

"quarkus.hibernate-orm.log.sql" now supports an extended option, which enables logging of bind params
closes #3075

@machi1990 machi1990 added the area/hibernate-orm Hibernate ORM label Feb 29, 2020
Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments inline. Thanks!

"quarkus.hibernate-orm.log.bindparam" added for logging of bind parameters
@Postremus Postremus force-pushed the #3075-orm-bind-param-logging branch from 0267ff4 to 30c90a9 Compare March 6, 2020 20:52
@Postremus
Copy link
Member Author

@dmlloyd @gunnarmorling
I addressed every point of the first round of reviews.
Onto the next round :D

@Postremus
Copy link
Member Author

@gunnarmorling ping

Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm lacking permission to merge. @gsmet?

@Sanne Sanne added the kind/enhancement New feature or request label Mar 26, 2020
@Sanne Sanne added this to the 1.4.0 milestone Mar 26, 2020
@Sanne Sanne merged commit 8501c9f into quarkusio:master Mar 26, 2020
@Sanne
Copy link
Member

Sanne commented Mar 26, 2020

thanks all, very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ORM] Add option for logging bind variables
5 participants