-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add short-name to reactive-messaging-amqp extension metadata #7515
Conversation
CI build run passed on my fork at: https://github.com/gemmellr/quarkus/actions/runs/48190219 |
@cescoffier could you give this a look and see what you think? |
The CI issue seems to be from a timeout issue with the KafkaStreamsTest creating a topic, rather than anything from the change itself (which doesn't change that module, and already passed in the fork). I cant restart the test so someone else will need to if required. |
Rebased to provoke a rebuild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which extensions are returned when you try to add |
Historically, using -Dextensions="amqp" just went ahead and used smallrye-reactive-messaging-amqp. Thats what the patch aims to preserve. I noticed in some testing I was doing that the extension I have a PR open at Quarkus Platform for Qpid's AMQP JMS client (quarkusio/quarkus-platform#28) also then got picked up by just specifying "amqp" as the guide for smallrye-reactive-messaging-amqp suggested. (I had originally thought that -Dextensions="..." needed the artifact id, but evidently its smarter as I came to realise from the guide). Realising that similar situation arises with the kafka extensions (where -Dextensions="kafka" simply uses smallrye-reactive-messaging-kafka, despite e.g kafka-streams and kafka-client also existing) I came to the conclusion the short-name was what made that work. I tried it out and found it got -Dextensions="amqp" back to simply using smallrye-reactive-messaging-amqp, and so raised this PR to retain the prior behaviour. |
Merged, thanks! |
The guide at https://quarkus.io/guides/amqp for the reactive-messaging-amqp extension indicates use of -Dextensions="amqp" when creating application template with quarkus-maven-plugin. When other extensions (e.g. in quarkus platform) also reference AMQP in their details the existing creation command fails as quarkus-maven-plugin detects multiple extensions.
The same scenario of multiple extensions exists for the reactive-messaging-kafka extension and its guide https://quarkus.io/guides/kafka, however in practice the scenario with -Dextensions="kafka" actually does work regardless.
The difference seems to be that the reactive-messaging-kafka extension defines an additional short-name metadata at:
https://github.com/quarkusio/quarkus/blob/1.2.1.Final/extensions/smallrye-reactive-messaging-kafka/runtime/src/main/resources/META-INF/quarkus-extension.yaml#L4
This PR makes similar addition to the reactive-messaging-amqp extension to maintain the historic behaviour.