Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a useful error message when native image fails with OOM #7645

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Provide a useful error message when native image fails with OOM #7645

merged 1 commit into from
Mar 6, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 6, 2020

Fixes: #6084

@geoand geoand mentioned this pull request Mar 6, 2020
Closed
gsmet
gsmet requested changes Mar 6, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very useful addition, thanks!

I added some very minor comments.

@geoand
Copy link
Contributor Author

geoand commented Mar 6, 2020

Thanks for the review @gsmet! Feedback applied

@geoand geoand added this to the 1.4.0 milestone Mar 6, 2020
@geoand geoand marked this pull request as ready for review March 6, 2020 14:01
@gsmet gsmet merged commit 14fbdf2 into quarkusio:master Mar 6, 2020
@geoand geoand deleted the oom-message branch March 6, 2020 15:43
@gsmet gsmet modified the milestones: 1.4.0, 1.3.0.CR2 Mar 6, 2020
@gwenneg gwenneg mentioned this pull request Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
1.3.0.CR2
Development

Successfully merging this pull request may close these issues.

build native via docker could have more informative error messages
2 participants
@geoand @gsmet