fix: allow Flyway and Liquibase to play together by making JdbcDataSourceSchemaReadyBuildItem a multiple build item #7658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urceSchemaReadyBuildItem a multiple build item The liquibase extension was merged in quarkusio#6334 which means that we have multiple possibilities of making a DB schema ready. This makes the build item that controls whether DB schemas are ready a mutliple build item so that it can be produced by several extensions. Without this we have the following extensions when we try to cohabite Flyway and Liquibase ``` io.quarkus.builder.ChainBuildException: Multiple producers of item class io.quarkus.agroal.deployment.JdbcDataSourceSchemaReadyBuildItem(io.quarkus.flyway.FlywayProcessor#configureRuntimeProperties) ``` Also avoid the usage of star imports in liquibase integration tests
gsmet
approved these changes
Mar 6, 2020
|
Thanks @gsmet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The liquibase extension was merged in #6334 which means that we have multiple possibilities of making a DB schema ready.
This makes the build item that controls whether DB schemas are ready a mutliple build item so that it can be produced by several extensions.
Without this we have the following extensions when we try to cohabite Flyway and Liquibase
Also avoid the usage of star imports in liquibase integration tests