Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent BannerProcessor from failing when builds done in parallel #7693

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Prevent BannerProcessor from failing when builds done in parallel #7693

merged 1 commit into from
Mar 9, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 9, 2020 •
edited
Loading

Fixes: #7689

@geoand geoand mentioned this pull request Mar 9, 2020
Closed
@ppalaga
Copy link
Contributor

ppalaga commented Mar 9, 2020

Looks good, thanks @geoand !

@geoand
Copy link
Contributor Author

geoand commented Mar 9, 2020

Thanks for reporting and checking @ppalaga!

@geoand
Copy link
Contributor Author

geoand commented Mar 9, 2020

@maxandersen could you please approve?

@geoand geoand added this to the 1.4.0 milestone Mar 9, 2020
@geoand geoand marked this pull request as ready for review March 9, 2020 12:55
@maxandersen
Copy link
Member

Looks good! +1 @geoand

@maxandersen maxandersen self-requested a review March 9, 2020 13:30
@geoand
Copy link
Contributor Author

geoand commented Mar 9, 2020

Thanks!

@geoand geoand merged commit b20a747 into quarkusio:master Mar 9, 2020
@geoand geoand deleted the banner-parallel branch March 9, 2020 14:16
@gsmet gsmet modified the milestones: 1.4.0, 1.3.0.CR2 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen maxandersen approved these changes

@ppalaga ppalaga ppalaga approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
1.3.0.CR2
Development

Successfully merging this pull request may close these issues.

FileSystemAlreadyExistsException when recordBanner is run in parallel
4 participants
@geoand @ppalaga @maxandersen @gsmet