Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary open modifier for Kotlin tests #7720

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Remove unnecessary open modifier for Kotlin tests #7720

merged 1 commit into from
Mar 10, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 10, 2020

These don't serve any purpose and even make IntelliJ
suggest to remove them

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/platform Issues related to definition and interaction with Quarkus Platform labels Mar 10, 2020
@geoand geoand requested a review from gastaldi March 10, 2020 08:08
@geoand geoand marked this pull request as ready for review March 10, 2020 09:19
@geoand
Remove unnecessary open modifier for Kotlin tests
538be51 
These don't serve any purpose and even make IntelliJ
suggest to remove them
@geoand geoand force-pushed the kotlin-test-open branch from db15fcf to 538be51 Compare March 10, 2020 10:53
gastaldi
gastaldi approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a Kotlin user but I trust you 😄

machi1990
machi1990 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit b19ea6c into quarkusio:master Mar 10, 2020
@geoand geoand deleted the kotlin-test-open branch March 10, 2020 12:18
@gsmet gsmet added this to the 1.4.0 milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@machi1990 machi1990 machi1990 approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
1.4.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@geoand @gastaldi @machi1990 @gsmet