Make GraalVM Java 11 the default image #7774
Conversation
|
@gwenneg I let you have a look and merge if it looks OK to you. |
|
Ok @gsmet, review in progress. |
|
Should we mention |
gsmet
force-pushed
the
java11-default-image
branch
from
9788695 to
964dff0
Compare
|
@gwenneg sorry about the mess! Can you have another look. I adjusted a few things to be more future proof. Also I removed a mention of the SunEC library as we think we don't need it anymore, right? |
| @@ -44,5 +44,6 @@ complete list of externalized variables for use is given in the following table: | |||
| |\{quickstarts-blob-url}|{quickstarts-blob-url}| Quickstarts URL to master blob source tree; used for referencing source files. | |||
| |\{quickstarts-tree-url}|{quickstarts-tree-url}| Quickstarts URL to master source tree root; used for referencing directories. | |||
|
|
|||
| |\{graalvm-version}|{graalvm-version}| Recommended Graal VM version to use. | |||
| |\{graalvm-version}|{graalvm-version}| Recommended GraalVM version to use. | |||
| |\{graalvm-flavor}|{graalvm-flavor}| The full flavor of GraaVM to use e.g. `19.3.1-java11`. | |||
There was a problem hiding this comment.
This is unrelated to this PR, but why do we need two columns (Property Name and Value) while they contain the exact same content for all lines of the table?
There was a problem hiding this comment.
They do not. One is escaped, not the other.
There was a problem hiding this comment.
Oh I missed that detail, sorry :)
There was a problem hiding this comment.
I can see the HTML with different values in quarkus-documentation-999-SNAPSHOT.zip, but is this file actually published somewhere on a public website? I can't find it anywhere on https://quarkus.io/.
There was a problem hiding this comment.
On GH, there isn't any difference in terms of display between columns 1 and 2.
There was a problem hiding this comment.
No, it's not. It's just for reference, we don't publish it.
That would be a GH bug :).
There was a problem hiding this comment.
Then I still don't understand why we need the Value column.
gsmet
force-pushed
the
java11-default-image
branch
from
b7835cf to
adaa68e
Compare
|
@gwenneg I took another shot. |
That's correct. |
|
@gwenneg thanks for the thorough review! |
No description provided.