Generate entities in correct class loader #7831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Mar 12, 2020
| @@ -760,7 +760,7 @@ private void enhanceEntities(final JpaEntitiesBuildItem domainObjects, | |||
| try { | |||
| byte[] bytes = IoUtil.readClassAsBytes(HibernateOrmProcessor.class.getClassLoader(), className); | |||
| byte[] enhanced = hibernateEntityEnhancer.enhance(className, bytes); | |||
| additionalClasses.produce(new GeneratedClassBuildItem(true, className, enhanced != null ? enhanced : bytes)); | |||
| additionalClasses.produce(new GeneratedClassBuildItem(false, className, enhanced != null ? enhanced : bytes)); | |||
There was a problem hiding this comment.
We are enhancing application classes and I don't understand why the enhanced classes should not be considered application classes?
There was a problem hiding this comment.
These are AdditionalJpaModelBuildItem classes, that are for entities defined in extensions. If we generate them in the application class loader then you end up with two copies, one in the runtime class loader and the original unmodified one in the base runtime class loader. Normally this is ok, unless a class in the base runtime CL attempts to use the entity, in which case you get problems.
gsmet
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7433