Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to SmallRye Health 2.2.0 #7978

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Update to SmallRye Health 2.2.0 #7978

merged 1 commit into from
Mar 20, 2020

Conversation

antoinesd
Copy link
Contributor

Add @healthGroup and @HealthGroups support

@antoinesd antoinesd requested a review from kenfinnigan March 19, 2020 14:30
@gsmet
Copy link
Member

gsmet commented Mar 19, 2020

@antoinesd @kenfinnigan is it necessary for MP 3.3 implementation? In other words: do we need to backport this to 1.3?

@kenfinnigan
Copy link
Member

It's not part of the spec so not required.

Having for 1.4 is fine

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 19, 2020
@gastaldi gastaldi added this to the 1.4.0 milestone Mar 19, 2020
gsmet
gsmet previously requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the 2 commits?

Thanks!

@kenfinnigan @antoinesd
Update to SmallRye Health 2.2.0
65c2138 
Add @healthGroup and @HealthGroups support
@antoinesd
Copy link
Contributor Author

Done

@geoand geoand dismissed gsmet’s stale review March 20, 2020 10:36

commits have been squashed

@gastaldi gastaldi merged commit b814d2a into quarkusio:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@geoand geoand geoand approved these changes

@xstefank xstefank xstefank approved these changes

@gsmet gsmet gsmet left review comments

@kenfinnigan kenfinnigan Awaiting requested review from kenfinnigan

Assignees
No one assigned
Labels
area/smallrye triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.4.0.CR1
Development

Successfully merging this pull request may close these issues.
6 participants
@antoinesd @gsmet @kenfinnigan @gastaldi @geoand @xstefank