Alexa SkillStreamHandler subclass check for RequestStreamHandler in AmazonLambdaProcessor #7985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/amazon-lambda
area/dependencies
gsmet
requested changes
Mar 19, 2020
...mbda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java
Outdated
Show resolved
Hide resolved
oztimpower
force-pushed
the
tp/lambda-stream-handler
branch
from
2b724ed to
d9d2d37
Compare
oztimpower
force-pushed
the
tp/lambda-stream-handler
branch
from
d9d2d37 to
caf7ae6
Compare
gsmet
approved these changes
Mar 19, 2020
|
This is very cool, thanks! |
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestion of @gsmet on #7955, I have added a simple 2 line check for subclasses of the Alexa SkillStreamHandler in the Amazon Lambda extension deployment module, AmazonLambdaProcessor.
It worked with my sample project.
runtime bom updated with the relevant Alexa SDK dependency, which also excludes conflicting dependencies of sl4j. Checked via mvn dependency:tree
/cc @gsmet
/cc @geoand
/cc @patriot1burke