Fix MySQL high availability not working in native mode #8052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Mar 21, 2020
machi1990
force-pushed
the
fix/7936
branch
2 times, most recently
from
337e21a to
92828c6
Compare
… in native mode Make sure that abandoned threads are cleaned up even in native mode using the same algorithm used in JVM mode.
Fixes quarkusio#7936 I was able to reproduce the error and adding the missing proxy registration fixed it. To test the fix, using the below mysql replication setup: ``` docker run \ --name mysql_primary \ -p 3306:3306 \ -e MYSQL_ROOT_PASSWORD=hibernate_orm_test \ -e MYSQL_USER=hibernate_orm_test \ -e MYSQL_PASSWORD=hibernate_orm_test \ -e MYSQL_DATABASE=hibernate_orm_test \ -e REPLICATION_USER=hibernate_orm_test \ -e REPLICATION_PASSWORD=hibernate_orm_test \ actency/docker-mysql-replication:5.7 ``` And on another terminal tab, run the following command: ``` docker run \ --name mysql_secondary \ -p 3307:3306 \ -e MYSQL_ROOT_PASSWORD=hibernate_orm_test \ -e MYSQL_USER=hibernate_orm_test \ -e MYSQL_PASSWORD=hibernate_orm_test \ -e MYSQL_DATABASE=hibernate_orm_test \ -e REPLICATION_USER=hibernate_orm_test \ -e REPLICATION_PASSWORD=hibernate_orm_test \ --link mysql_primary:master \ actency/docker-mysql-replication:5.7 ``` Open another terminal tab and launch jdbc-mysql integration tests with the following command `cd integration-tests/jpa-mysql` and then open the configuration file and edit the jdbc url so that it points to: ``` jdbc:mysql:replication://localhost:3306,localhost:3307/hibernate_orm_test?connectTimeout=5000&socketTimeout=5000&retriesAllDown=3&allowMasterDownConnections=true&allowSlaveDownConnections=true&loadBalanceBlacklistTimeout=10000&readFromMasterWhenNoSlaves=true` ``` Then running ``` mvn clean install -Dnative -Dtest-mysql ``` Should pass successfully which was not the case previously as it was throwing missing proxy registration errors
gsmet
approved these changes
Mar 24, 2020
|
Merged, thanks. Nice work! |
|
Great thanks. |
|
I backported the second commit. |
|
Thanks @gsmet |
|
Solves my problem. |
|
Thanks for confirming! |
@SchulteMarkus , thanks for testing and confirming. |
|
Failover with mysql is not working in 1.5.0.Final, can someone help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7936
I was able to reproduce the error and adding the missing proxy registration fixed it.
To test the fix, using the below mysql replication setup:
And on another terminal tab, run the following command:
Open another terminal tab and launch jdbc-mysql integration tests with the following command
cd integration-tests/jpa-mysqland then open the configuration file and edit the jdbc url so that it points to:Then running
Should pass successfully which was not the case previously as it was throwing missing proxy registration errors.
@SchulteMarkus can you check if this fixes the error for you?
PS: The first commit adds connection clean up in native mode. Let me know what you think about it?
/cc @Sanne @geoand @gsmet