fix(flyway): multiple datasource migration does not work on native #8065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QuarkusPathLocationScanner returned all migrations locations by default, this risked to cause collision when we have a same filename for a migration script which is handled by different datasources - a behaviour encountered on the issue quarkusio#7685. Let's avoid this case by making sure that the scanner only returns migration that it can recognize. Fixes quarkusio#7685
gsmet
requested changes
Mar 23, 2020
extensions/flyway/deployment/src/main/java/io/quarkus/flyway/FlywayProcessor.java
Outdated
Show resolved
Hide resolved
extensions/flyway/deployment/src/main/java/io/quarkus/flyway/FlywayProcessor.java
Show resolved
Hide resolved
...flyway/runtime/src/main/java/io/quarkus/flyway/runtime/graal/QuarkusPathLocationScanner.java
Outdated
Show resolved
Hide resolved
gastaldi
reviewed
Mar 24, 2020
extensions/flyway/deployment/src/main/java/io/quarkus/flyway/FlywayProcessor.java
Show resolved
Hide resolved
gsmet
approved these changes
Mar 24, 2020
|
Thanks @machi1990 ! |
|
@machi1990 btw, we have the same weird pattern of writing files in the Liquibase extension. Maybe we could get rid of it too? |
Sure, I'll look at it. Thanks for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QuarkusPathLocationScanner returned all migrations locations by default, this risked to cause
collision when we have a same filename for a migration script which is handled by different
datasources - a behaviour encountered on the issue #7685. Let's avoid this case by making sure that
the scanner only returns migration that it can recognize.
Fixes #7685
/cc @yanxuehe this should fix the issue for you.