Move 1.3 to Java 11 by default #8153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be it for Windows and for the native builds.
The path was incorrect so it didn't work and, indeed, we need the artifacts for the native builds.
boring-cyborg
bot
added
area/core
area/devtools
|
Please don't merge, I will merge it myself. |
gastaldi
approved these changes
Mar 25, 2020
|
@geoand It's marked for backport already, I will backport it separately when I do my mass backporting. |
|
OK gotcha! |
By default, it is based on the Java version used to create the project. It can be overridden in CreateProject though if you really want to enforce it in your tools. I haven't exposed it for now as we will probably remove it or tweak it later. Note that even if you enforce it, it will still use either 8 or 11 for now. We might want to further enhance that later.
boring-cyborg
bot
added
the
area/platform
gastaldi
approved these changes
Mar 25, 2020
|
This looks good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I backported everything that's needed except for the deprecation warnings that should be only for 1.4.
/cc @gwenneg @dmlloyd @gastaldi @geoand