Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the usage of unrecommended private members in Naryana JTA integration tests application beans #8245

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

machi1990
Copy link
Member

Otherwise log messages like the one below were printed when running tests, let's get rid of them.

2020-03-28 20:26:18,276 INFO  [io.qua.arc.pro.BeanProcessor] (build-11) Found unrecommended usage of private members (use package-private instead) in application beans:
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#beanEvents,
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#beanTransactional,
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#tm,
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#tx,
	- @Inject field io.quarkus.narayana.jta.TransactionBeanWithEvents#tm

@boring-cyborg boring-cyborg bot added the area/narayana Transactions / Narayana label Mar 29, 2020
@machi1990 machi1990 requested a review from gastaldi March 29, 2020 00:28
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@gastaldi gastaldi added this to the 1.4.0 milestone Mar 29, 2020
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 29, 2020
… JTA integration tests application beans

Otherwise log messages like the one below were printed when running tests, let's get rid of them.

```
2020-03-28 20:26:18,276 INFO  [io.qua.arc.pro.BeanProcessor] (build-11) Found unrecommended usage of private members (use package-private instead) in application beans:
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#beanEvents,
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#beanTransactional,
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#tm,
	- @Inject field io.quarkus.narayana.jta.TransactionScopedTest#tx,
	- @Inject field io.quarkus.narayana.jta.TransactionBeanWithEvents#tm
```
@machi1990 machi1990 force-pushed the clean-ups-naryana-it branch from 17d930d to ab6a77f Compare March 29, 2020 09:15
@machi1990 machi1990 merged commit 8c30cc2 into quarkusio:master Mar 29, 2020
@machi1990 machi1990 deleted the clean-ups-naryana-it branch March 29, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/narayana Transactions / Narayana triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants