-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added orm panache hot reload test #8305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I would personally use RESTAssured's capability of extracting pieces from json and asserting them instead of the whole body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks!
Bah, I felt like I wanted to test that the output reflected the changes and not necessarily test JSON parsing. |
Yeah, I understand :) |
Tests seem to have failed |
Yeah, damnit. The test fails sometimes, apparently due to ORM sometimes not executing the |
If it caught an error, the test has already proven it's worth, although it may have been more that you bargained for :P |
@Sanne these logs show that I'm creating the DB fine, and Can the |
@Sanne forget it, it's not that at all. |
Famous Last Words™ |
5b2d497
to
50f474b
Compare
Should pass now. |
What was it? |
Don't ask. |
PBKAC. |
No description provided.