Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keycloak admin client #8315

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

stuartwdouglas
Copy link
Member

Fixes #6350

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/documentation area/oidc labels Apr 1, 2020
@gastaldi gastaldi requested review from pedroigor and sberyozkin April 1, 2020 03:11
@sberyozkin sberyozkin added this to the 1.4.0 milestone Apr 1, 2020
@sberyozkin
Copy link
Member

Hi Stuart @stuartwdouglas, nice and simple, thanks.
I'd only consider move the tests to integration-tests/oidc as integration-tests/oidc-code-flow, as a lot is already going on the other oidc-code-flow tests :-).
Pedro, @pedroigor, what do you think about updating KeycloakRealmResourceManager ? This now also works over HTTPS. I suppose updating a single KeycloakRealmResourceManager would do.

@sberyozkin
Copy link
Member

@gsmet Hi, I've removed a backport label for now as I'm not 100% sure it is a new feature or a bug fix :-)

Copy link
Contributor

@pedroigor pedroigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a learning experience to see @stuartwdouglas code and how to do simple things that work in Quarkus.

@sberyozkin
Copy link
Member

@pedroigor I'm replacing this code now, pretty simple with the admin client :-)

@pedroigor
Copy link
Contributor

@sberyozkin Yeah, it should make things lot simpler when interacting to Keycloak REST API.

@sberyozkin
Copy link
Member

@pedroigor I'm having issues in replacing the code across all the tests (this is only related to the use of the API, Stuart's PR is fine), so I will just update oidc-code-flow resource and it should be ready to go

@sberyozkin sberyozkin force-pushed the keycloak-admin-client branch from 4fa0bd0 to a7821db Compare April 1, 2020 16:48
@sberyozkin
Copy link
Member

sberyozkin commented Apr 1, 2020

Hi @pedroigor So I've updated oidc-code-flow and keycloak-authorization.
oidc did not work as it now uses HTTPS and there is only a single factory method in the api which allows to disable the trust manager, I thought it worked but then in the end it did not. I also could not update oidc-multitenancy. I'm not worried at all, it is really about the correct use of the API, so may be you can have a look later on or may be we can keep some RestAssured code there too.
IMHO it is now ready to go :-)

@sberyozkin sberyozkin added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 1, 2020
@sberyozkin sberyozkin merged commit 8cf498c into quarkusio:master Apr 1, 2020
@BuildStep
ReflectiveHierarchyIgnoreWarningBuildItem marker(BuildProducer<AdditionalApplicationArchiveMarkerBuildItem> prod) {
prod.produce(new AdditionalApplicationArchiveMarkerBuildItem("org/keycloak/admin/client/"));
prod.produce(new AdditionalApplicationArchiveMarkerBuildItem("org/keycloak/representations"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartwdouglas I wonder if we should index the jar instead so that things are properly registered for reflection? Otherwise, there's a good chance things won't work very well in native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/oidc release/noteworthy-feature triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keycloak Admin Client does not work with Quarkus because it depends on RestEasy 3.x
4 participants