-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate buildNative gradle task #8325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the io.quarkus.gradle.QuarkusPluginFunctionalTest
too I suppose
Also make sure the Gradle tests pass in your environment by running |
Thank you for the review, I'm checking why the build fails. |
Thanks for the contribution @glefloch, can we squash the commits into one? |
Yes, for sure, I squashed commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments below. Can you verify them before we merge it?
devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusNative.java
Outdated
Show resolved
Hide resolved
devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusNative.java
Outdated
Show resolved
Hide resolved
devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusNative.java
Outdated
Show resolved
Hide resolved
testNative.setShouldRunAfter(Collections.singletonList(tasks.findByName(JavaPlugin.TEST_TASK_NAME))); | ||
|
||
project.getGradle().getTaskGraph().whenReady(taskGraph -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already done in configureBuildNativeTask(...)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, yes, you right, I moved out the logger and used task path instead of task reference.
It seems that the warning shows only after |
Also, don't forget to update the READMEs generated when a project is created: |
Well, we could either move the warning in the |
I am not sure which is better. I'll let you decide 😉 |
@gastaldi, I updated
WDYT? |
devtools/gradle/src/main/java/io/quarkus/gradle/QuarkusPlugin.java
Outdated
Show resolved
Hide resolved
7ad072d
to
b63baf7
Compare
this pull request deprecates gradle buildNative task.
close #7104