Project root should not initialized to the current dir if the test class is from a JAR #8467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initialized to the current dir * Propagate project's managed dependencies to the deployment dependency trees
aloubyansky
force-pushed
the
no-project-root-for-test-from-jar
branch
from
0a20595 to
4a87f53
Compare
boring-cyborg
bot
added
the
area/devtools
|
I wish we had more tests for this scenario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8452
There is a bit of a mess around
appClassesandprojectRootin the bootstrap and the resolver. I'm cleaning it up in a different PR.The other issue is that the output of
build-treeisn't really working for an external test JAR.