Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle non-http service in s2i #8490

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Properly handle non-http service in s2i #8490

merged 1 commit into from
Apr 9, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 9, 2020

Fixes: #8481

@geoand geoand requested review from gastaldi and iocanel April 9, 2020 05:06
@geoand geoand added this to the 1.4.0 milestone Apr 9, 2020
@geoand geoand force-pushed the #8481 branch 2 times, most recently from 2fd43b1 to 50cc839 Compare April 9, 2020 05:16
@geoand geoand marked this pull request as ready for review April 9, 2020 07:47
@geoand
Copy link
Contributor Author

geoand commented Apr 9, 2020

@iocanel, OK with you too?

@geoand geoand merged commit 39a989e into quarkusio:master Apr 9, 2020
@geoand geoand deleted the #8481 branch April 9, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@iocanel iocanel Awaiting requested review from iocanel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0.CR1
Development

Successfully merging this pull request may close these issues.

image build fails without resteasy using quarkus-openshift extension
2 participants
@geoand @gastaldi