-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactive routes - improve @Route method invocation performance #8536
Conversation
@johnaohara FYI this could improve the performance of |
@mkouba i'll try it out, thanks |
3290f98
to
6d293be
Compare
@johnaohara Did you get a chance to test this branch? Anyway, I think that it wouldn't hurt to merge this even though we have no perf numbers yet. |
Approx 3.3% improvement in throughput for simple plain text test
|
@johnaohara thanks! |
@gsmet Unfortunately, there is a bug in this PR. Thanks @michalszynkiewicz for spotting the problem. I'm going to send a fix shortly. |
Looks like we need more tests :). |
Well, I don't think that regular tests would cover this. It's a race condition... caused by my inattention. |
Reactive routes - improve @route method invocation performance
No description provided.