Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive routes - improve @Route method invocation performance #8536

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 11, 2020

No description provided.

@mkouba
Copy link
Contributor Author

mkouba commented Apr 11, 2020

@johnaohara FYI this could improve the performance of @Route method invocations a little bit. Although I'm not quite sure it would make any significat difference in your use case.

@johnaohara
Copy link
Member

@mkouba i'll try it out, thanks

@mkouba mkouba force-pushed the vertx-web-route-perf branch from 3290f98 to 6d293be Compare April 14, 2020 11:35
@mkouba
Copy link
Contributor Author

mkouba commented Apr 14, 2020

@johnaohara Did you get a chance to test this branch?

Anyway, I think that it wouldn't hurt to merge this even though we have no perf numbers yet.

@mkouba mkouba marked this pull request as ready for review April 14, 2020 11:36
@mkouba mkouba requested a review from cescoffier April 14, 2020 11:36
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 14, 2020
@johnaohara
Copy link
Member

Approx 3.3% improvement in throughput for simple plain text test

2020-04-14 12:12:06,470 INFO  [io.quarkus] (main) code-with-quarkus 1.0.0-SNAPSHOT (powered by Quarkus 1.3.1.Final) started in 0.583s. Listening on: http://0.0.0.0:8080


$ wrk -c 100 -t 4 -d 30s http://benchserver4G1:8080/hello/John
Running 30s test @ http://benchserver4G1:8080/hello/John
  4 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     7.82ms   13.21ms  54.63ms   82.37%
    Req/Sec    30.45k     2.16k   46.01k    72.09%
  3646069 requests in 30.10s, 170.38MB read
Requests/sec: 121132.29
Transfer/sec:      5.66MB




2020-04-14 12:14:46,529 INFO  [io.quarkus] (main) code-with-quarkus 1.0.0-SNAPSHOT (powered by Quarkus 999-SNAPSHOT) started in 0.595s. Listening on: http://0.0.0.0:8080


$ wrk -c 100 -t 4 -d 30s http://benchserver4G1:8080/hello/John
Running 30s test @ http://benchserver4G1:8080/hello/John
  4 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     7.69ms   13.06ms  53.55ms   82.44%
    Req/Sec    31.49k     1.93k   43.40k    71.49%
  3767409 requests in 30.10s, 176.05MB read
Requests/sec: 125163.16
Transfer/sec:      5.85MB

@mkouba
Copy link
Contributor Author

mkouba commented Apr 14, 2020

@johnaohara thanks!

@mkouba mkouba merged commit 06dc695 into quarkusio:master Apr 14, 2020
@gsmet gsmet added this to the 1.4.0.CR1 milestone Apr 14, 2020
@mkouba
Copy link
Contributor Author

mkouba commented Apr 15, 2020

@gsmet Unfortunately, there is a bug in this PR. Thanks @michalszynkiewicz for spotting the problem. I'm going to send a fix shortly.

@gsmet
Copy link
Member

gsmet commented Apr 15, 2020

Looks like we need more tests :).

@mkouba
Copy link
Contributor Author

mkouba commented Apr 15, 2020

Well, I don't think that regular tests would cover this. It's a race condition... caused by my inattention.

mkouba added a commit to mkouba/quarkus that referenced this pull request Apr 15, 2020
michalszynkiewicz pushed a commit to michalszynkiewicz/quarkus that referenced this pull request Apr 15, 2020
matejvasek pushed a commit to matejvasek/quarkus that referenced this pull request Apr 15, 2020
Reactive routes - improve @route method invocation performance
mkouba added a commit to mkouba/quarkus that referenced this pull request Apr 16, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Apr 20, 2020
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertx triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants