Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute if section - consider truthy/falsy values during evaluation #8602

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Qute if section - consider truthy/falsy values during evaluation #8602

merged 1 commit into from
Apr 16, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 15, 2020

@mkouba mkouba requested review from gsmet and Ladicek April 15, 2020 19:20
@mkouba mkouba added this to the 1.4.0.Final milestone Apr 15, 2020
@mkouba mkouba added the area/qute The template engine label Apr 15, 2020
@Ladicek
Copy link
Contributor

Ladicek commented Apr 16, 2020

Overall LGTM (with the condition that I've never seen the Qute codebase before :-) ), just added a few minor comments.

@mkouba mkouba force-pushed the issue-8582 branch 3 times, most recently from dfb1994 to 3c031d8 Compare April 16, 2020 07:51
@mkouba
Copy link
Contributor Author

mkouba commented Apr 16, 2020

@Ladicek so I believe that the current proposal is robust enough.

@mkouba mkouba modified the milestones: 1.4.0.Final, 1.5.0 Apr 16, 2020
@Ladicek
Copy link
Contributor

Ladicek commented Apr 16, 2020

I don't feel like approving for real, because I don't understand the rest of the code, but the isFalsy method looks good to me.

@mkouba
Copy link
Contributor Author

mkouba commented Apr 16, 2020

but the isFalsy method looks good to me.

That's enough ;-). I need some approval anyway because I can't "force merge" anymore...

@gsmet gsmet merged commit 809126a into quarkusio:master Apr 16, 2020
@gsmet gsmet modified the milestones: 1.5.0, 1.4.0.Final Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation area/qute The template engine
Projects
None yet
Milestone
1.4.0.Final
Development

Successfully merging this pull request may close these issues.

Qute IfSectionHelper - consider truthy values during evaluation
3 participants
@mkouba @Ladicek @gsmet