Resteasy: do not use Jandex's ClassInfo in a Set #8687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… neither equals() nor hashCode()
geoand
reviewed
Apr 20, 2020
Comment on lines
+238
to
+242
| String className = clazz.name().toString(); | ||
| if (!additionalPaths.contains(annotation)) { // scanned resources only contains real JAX-RS resources | ||
| scannedResources.putIfAbsent(clazz.name(), clazz); | ||
| } | ||
| reflectiveClass.produce(new ReflectiveClassBuildItem(true, true, className)); |
There was a problem hiding this comment.
Shouldn't these be outside of the if (!withoutDefaultCtor.containsKey(clazz.name())) check?
There was a problem hiding this comment.
If it's in withoutDefaultCtor it's already been processed, hasn't it?
There was a problem hiding this comment.
That is certainly true, but the point of withoutDefaultCtor wasn't really to guard against that case.
I do understand what your checking here, it just seems odd to reuse withoutDefaultCtor to perform this check.
There was a problem hiding this comment.
I could introduce another Set for that purpose.
|
Let's get this one in for now |
geoand
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it implements neither equals() nor hashCode()