Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken health / live probes when container-image name is set #8735

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix broken health / live probes when container-image name is set #8735

merged 1 commit into from
Apr 22, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 22, 2020

Fixes: #8733

@geoand geoand requested a review from iocanel April 22, 2020 06:46
@geoand
Copy link
Contributor Author

geoand commented Apr 22, 2020

@gsmet do we have time to backport this one if it is merged in a couple hours?

iocanel
iocanel approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet
Copy link
Member

gsmet commented Apr 22, 2020

Sure I will backport until this evening.

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport-1.3? labels Apr 22, 2020
@geoand
Copy link
Contributor Author

geoand commented Apr 22, 2020

Thanks!

@geoand geoand merged commit 974c3a8 into quarkusio:master Apr 22, 2020
@geoand geoand deleted the #8733 branch April 22, 2020 08:34
@geoand geoand changed the title Fix broken health / live probes when container-image name was set Fix broken health / live probes when container-image name is set Apr 22, 2020
@gsmet gsmet added this to the 1.4.0.Final milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.4.0.Final
Development

Successfully merging this pull request may close these issues.

Kubernetes probes not added when using container-image.name
3 participants
@geoand @gsmet @iocanel