Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how nested MDC scopes are handled in the Jaeger extension #8778

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Apr 23, 2020

This is a follow-up to #8746.

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 23, 2020

Draft to let CI run in my fork.

@pavolloffay could you please take a look? Thanks!

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 23, 2020

Un-WIP-ing, CI passed in my fork.

@Ladicek Ladicek marked this pull request as ready for review April 23, 2020 14:10
@gsmet gsmet force-pushed the nested-mdc-scopes-improvement branch from eb5a46a to b2f595e Compare April 23, 2020 19:51
@gsmet
Copy link
Member

gsmet commented Apr 23, 2020

Rebased and force pushed, CI went berserk.

@gsmet gsmet changed the title improve how nested MDC scopes are handled in the Jaeger extension Improve how nested MDC scopes are handled in the Jaeger extension Apr 23, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @pavolloffay

@gsmet gsmet merged commit def0378 into quarkusio:master Apr 23, 2020
@gsmet gsmet added this to the 1.5.0 milestone Apr 23, 2020
@gsmet gsmet modified the milestones: 1.5.0, 1.4.0.Final Apr 23, 2020
@Ladicek Ladicek deleted the nested-mdc-scopes-improvement branch April 24, 2020 08:01
@gsmet gsmet modified the milestones: 1.4.0.Final, 1.4.1.Final Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants