Fix issue with build time config in dev mode #9436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
May 19, 2020
...loyment/src/main/java/io/quarkus/deployment/configuration/RunTimeConfigurationGenerator.java
Outdated
Show resolved
Hide resolved
|
Tested this PR with #9415 and it works like a charm! Fixes seems reasonable to me, 👍 |
geoand
approved these changes
May 19, 2020
|
We'll need to restart CI, the failures seems very weird and completely unrelated to the PR (I tried the Spring tests locally from this PR and they worked just fine). UPDATE : |
|
I pushed a commit with the test I added for Flyway (since CI needed a restart anyway) |
|
quay.io seems to still have problems :( |
gsmet
force-pushed
the
9296
branch
2 times, most recently
from
53c48f7 to
dcdf69b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9296
Fixes #9415