-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a TROUBLESHOOTING.md page with performance related tips #9462
Conversation
/cc @johnaohara maybe you have different tips for using async profiler ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE! Thank you!
Also added an ingore path to github action for all .md files as discussed on Zulip to avoid modifying it each time we add a .md file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, I think users will really appreciate it!
I added some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it's very good. Be aware, nitpicking coming!
|
||
For allocation profiling, you also need to install HotStop debug symbol. | ||
|
||
Depending on your Linux and Java distribution this can be done via: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I would recommend that. I think most people don't use the JDK from the distribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way to install debug info on a non-distribution JDK is way harder, you need to download it and build it (and building C code can fail in a lot of possible ways).
I can find a link to add but it's way easier to install it this way and use the JDK from the distribution to launch the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact you need to build your own JDK ...
In this case I would suggest to use a fastdebug build, it will be a slower JVM (JVM asserts will be enabled) but it includes debug symbols so it will works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a reference to fastdebug builds, didn't include a specific link but I could add one to https://builds.shipilev.net/ it's the only place I know where you can find those builds
cbf4879
to
50c8f13
Compare
50c8f13
to
7db7c04
Compare
Thanks @loicmathieu and co for this. I really like it. |
Where are we are on this one? Have all comments been addressed? |
I think we will need @gsmet's final blessing on this one ;) |
@gsmet can we merge this one? |
Lets go ahead and merge this since it is very helpful and there is only one comment that has not been addressed (cc @gsmet). We can improve this if needed. |
there is a one comment that hasn't been resolved, but I think it makes more sense to have this in and then look into improving
Following this discussion on Zulip: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Performance