Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TROUBLESHOOTING.md page with performance related tips #9462

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

loicmathieu
Copy link
Contributor

@loicmathieu
Copy link
Contributor Author

/cc @gsmet and @gastaldi

/cc @johnaohara maybe you have different tips for using async profiler ?

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! Thank you!

@boring-cyborg boring-cyborg bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label May 19, 2020
@loicmathieu
Copy link
Contributor Author

Also added an ingore path to github action for all .md files as discussed on Zulip to avoid modifying it each time we add a .md file.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, I think users will really appreciate it!

I added some suggestions

gsmet
gsmet previously requested changes May 19, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's very good. Be aware, nitpicking coming!


For allocation profiling, you also need to install HotStop debug symbol.

Depending on your Linux and Java distribution this can be done via:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I would recommend that. I think most people don't use the JDK from the distribution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way to install debug info on a non-distribution JDK is way harder, you need to download it and build it (and building C code can fail in a lot of possible ways).
I can find a link to add but it's way easier to install it this way and use the JDK from the distribution to launch the application.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact you need to build your own JDK ...
In this case I would suggest to use a fastdebug build, it will be a slower JVM (JVM asserts will be enabled) but it includes debug symbols so it will works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a reference to fastdebug builds, didn't include a specific link but I could add one to https://builds.shipilev.net/ it's the only place I know where you can find those builds

@loicmathieu loicmathieu force-pushed the doc/troubleshooting branch 3 times, most recently from cbf4879 to 50c8f13 Compare May 20, 2020 08:48
@loicmathieu loicmathieu force-pushed the doc/troubleshooting branch from 50c8f13 to 7db7c04 Compare May 20, 2020 09:13
@machi1990
Copy link
Member

Thanks @loicmathieu and co for this. I really like it.

@geoand
Copy link
Contributor

geoand commented May 22, 2020

Where are we are on this one? Have all comments been addressed?

@loicmathieu
Copy link
Contributor Author

I think we will need @gsmet's final blessing on this one ;)
Also this is not linked anywhere ATM.

@loicmathieu
Copy link
Contributor Author

@gsmet can we merge this one?

@geoand
Copy link
Contributor

geoand commented Jun 24, 2020

Lets go ahead and merge this since it is very helpful and there is only one comment that has not been addressed (cc @gsmet).

We can improve this if needed.

@geoand geoand dismissed gsmet’s stale review June 24, 2020 07:10

there is a one comment that hasn't been resolved, but I think it makes more sense to have this in and then look into improving

@geoand geoand merged commit cf41109 into quarkusio:master Jun 24, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 25, 2020
@loicmathieu loicmathieu deleted the doc/troubleshooting branch June 26, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure release/noteworthy-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants