Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VertxRequestHandler cleanup code changes #9574

Merged
merged 1 commit into from
Jul 13, 2020
Merged

VertxRequestHandler cleanup code changes #9574

merged 1 commit into from
Jul 13, 2020

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented May 25, 2020 •
edited
Loading

knative.events.VertxRequestHandler

  • Removal of unused local variables
  • Removal of unnecessary casts

OptaPlannerProcessor changes dropped

@geoand
Copy link
Contributor

geoand commented May 25, 2020

cc @ge0ffrey @patriot1burke

@gsmet
Copy link
Member

gsmet commented Jun 17, 2020

OptaPlannerProcessor is gone and there is a conflict with the other one.

@rsvoboda
Copy link
Member Author

Rebased, updating PR description now

@rsvoboda rsvoboda changed the title OptaPlannerProcessor and VertxRequestHandler cleanup code changes VertxRequestHandler cleanup code changes Jun 17, 2020
@rsvoboda
Copy link
Member Author

Native Tests - Data2 was aborted, timeout - ##[error]The operation was canceled.

Windows JDK 11 was aborted, timeout - ##[error]The operation was canceled.

@ge0ffrey
Copy link
Contributor

FYI Working with @rsvoboda to apply the cleanups originally in this PR downstream into the optaplanner-quarkus extension: https://github.com/kiegroup/optaplanner/blob/master/optaplanner-quarkus-integration/optaplanner-quarkus/deployment/src/main/java/org/optaplanner/quarkus/deployment/OptaPlannerProcessor.java#L62

@rsvoboda rsvoboda mentioned this pull request Jun 17, 2020
Merged
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 10, 2020
@gsmet
Copy link
Member

gsmet commented Jul 10, 2020

Rebased, let's merge as soon as CI is green.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 10, 2020
@gsmet gsmet merged commit 1176247 into quarkusio:master Jul 13, 2020
@rsvoboda rsvoboda deleted the OptaPlannerProcessor.and.VertxRequestHandler branch March 4, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

Assignees
No one assigned
Labels
area/funqy triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@rsvoboda @geoand @gsmet @ge0ffrey @machi1990