Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive datasource config: cache-prepared-statements is not specific to any DB #9644

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Reactive datasource config: cache-prepared-statements is not specific to any DB #9644

merged 2 commits into from
Jun 22, 2020

Conversation

tsegismont
Copy link
Contributor

Fixes #9642

@tsegismont
Copy link
Contributor Author

Created a draft PR for now as it is based on top of #9469 .

The only meaningful commit is a923557

@tsegismont tsegismont mentioned this pull request Jun 2, 2020
Merged
@tsegismont tsegismont marked this pull request as ready for review June 19, 2020 10:17
@tsegismont
Copy link
Contributor Author

@cescoffier @FroMage can one of you please review? Thank you

FroMage
FroMage requested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a better warning, this is good to merge.

@FroMage FroMage added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 22, 2020
@FroMage FroMage added this to the 1.6.0 - master milestone Jun 22, 2020
@Sanne Sanne merged commit 847ed40 into quarkusio:master Jun 22, 2020
@Sanne
Copy link
Member

Sanne commented Jun 22, 2020

great, thanks!

@Sanne Sanne added the area/persistence OBSOLETE, DO NOT USE label Jun 22, 2020
@gastaldi gastaldi mentioned this pull request Jun 23, 2020
Merged
@tsegismont
Copy link
Contributor Author

Thank you @Sanne and @FroMage !

@tsegismont tsegismont deleted the issue/9642 branch June 25, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/documentation area/persistence OBSOLETE, DO NOT USE area/reactive area/vertx triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.6.0.CR1
Development

Successfully merging this pull request may close these issues.

Reactive datasource config: cache-prepared-statements is not specific to any DB
3 participants
@tsegismont @Sanne @FroMage