Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to KC 10.0.1 and use quarkus-keycloak-admin-client in KC authorization tests #9669

Closed
wants to merge 1 commit into from

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented May 28, 2020

Updated to KC 10.0.1.
Also updated the tests to have only integration-tests/keycloak-authorization use quarkus-keycloak-admin-client to save some time on building the native image in integration-tests/oidc-code-flow which also has html unit. (CC @gsmet )

However one keycloak authorization test fails:

[ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.096 s <<< FAILURE! - in io.quarkus.it.keycloak.PolicyEnforcerTest
[ERROR] testUserHasRoleConfidential  Time elapsed: 0.288 s  <<< FAILURE!
java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <403>.

I've confirmed it still passes with KC 10.0.0 even with the moved AdminClientTestCase, so it might that there is a small regression in 10.0.1.

Hi Pedro, @pedroigor, can you please check when you have some time ? thanks

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/oidc labels May 28, 2020
@sberyozkin sberyozkin requested a review from pedroigor May 28, 2020 21:46
@pedroigor
Copy link
Contributor

@sberyozkin Is the test failure still happening?

@sberyozkin
Copy link
Member Author

Hi @pedroigor so yes, let me close this draft since you have a more comprehensive fix and also update to 10.0.2, thanks

@sberyozkin sberyozkin closed this Jun 2, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 10, 2020
@sberyozkin sberyozkin deleted the keycloak_10.0.1 branch September 16, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/keycloak-authorization area/oidc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants