Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: reading namespaced ConfigMaps #9728

Merged
merged 1 commit into from
Jul 7, 2020
Merged

feature: reading namespaced ConfigMaps #9728

merged 1 commit into from
Jul 7, 2020

Conversation

aureamunoz
Copy link
Member

@aureamunoz aureamunoz commented Jun 2, 2020 •
edited
Loading

Related to #8376

@aureamunoz aureamunoz mentioned this pull request Jun 2, 2020
Closed
@machi1990 machi1990 requested a review from geoand June 2, 2020 14:50
geoand
geoand requested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments I added, I am not all that sure about this to be honest.

I can see the appeal, but on the other hand if we want more flexibility, we would allow users to individually configure the namespace of the configmap.

@aureamunoz aureamunoz force-pushed the namespaced-configmap branch 2 times, most recently from 0ed026e to 2daa9b0 Compare June 25, 2020 09:28
@aureamunoz
Copy link
Member Author

Could you please assign the issue to me, @geoand ?

@geoand
Copy link
Contributor

geoand commented Jun 25, 2020

Done

@geoand geoand mentioned this pull request Jun 25, 2020
Merged
@aureamunoz aureamunoz force-pushed the namespaced-configmap branch from 2d7026d to f736200 Compare June 26, 2020 13:14
@aureamunoz
Copy link
Member Author

Finally 😅 When you have some time @geoand I will be happy if you can review this. Thanks!

@aureamunoz aureamunoz force-pushed the namespaced-configmap branch from f736200 to cbfa0cc Compare June 26, 2020 14:34
@aureamunoz
Copy link
Member Author

Thank you for the comments.

@geoand
Copy link
Contributor

geoand commented Jun 26, 2020 •
edited
Loading

👍

@geoand
Copy link
Contributor

geoand commented Jun 29, 2020

I'll review again later today

geoand
geoand reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that once we have the documentation issue I mentioned fixed, we can merge this

@aureamunoz aureamunoz force-pushed the namespaced-configmap branch from cbfa0cc to 9933872 Compare June 29, 2020 12:59
@aureamunoz
Copy link
Member Author

I added some comments to the docs, let me know wdyt @geoand

@aureamunoz aureamunoz force-pushed the namespaced-configmap branch from 9933872 to 64e56b0 Compare June 29, 2020 13:39
@aureamunoz
Copy link
Member Author

Thank you @geoand

geoand
geoand approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand
Copy link
Contributor

geoand commented Jun 29, 2020

The change might not pass formatting because I just added via Github suggestion

@aureamunoz aureamunoz force-pushed the namespaced-configmap branch from 64e56b0 to 37ca807 Compare June 29, 2020 21:07
@snowdrop-bot snowdrop-bot mentioned this pull request Jun 30, 2020
Closed
@aureamunoz aureamunoz force-pushed the namespaced-configmap branch from 37ca807 to 8616e89 Compare July 1, 2020 16:24
@aureamunoz
Copy link
Member Author

Finally checks passed, I have just rebate onto master.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 1, 2020
@aureamunoz aureamunoz force-pushed the namespaced-configmap branch 2 times, most recently from a728dfa to 34da544 Compare July 6, 2020 07:59
@aureamunoz aureamunoz force-pushed the namespaced-configmap branch from 34da544 to 1c89c51 Compare July 7, 2020 09:49
@aureamunoz
Copy link
Member Author

I rebased onto master and Checks passed @geoand :-)

@geoand geoand added this to the 1.7.0 - master milestone Jul 7, 2020
@geoand
Copy link
Contributor

geoand commented Jul 7, 2020

Thanks!

@geoand geoand merged commit 53de0f6 into quarkusio:master Jul 7, 2020
@geoand geoand deleted the namespaced-configmap branch July 7, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 left review comments

@geoand geoand geoand approved these changes

Assignees

@aureamunoz aureamunoz

Labels
area/documentation area/kubernetes area/testing triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@aureamunoz @geoand @machi1990